Skip to content

Remove unused/legacy translation method from video block#37776

Merged
farhan merged 2 commits intomasterfrom
farhan/remove-unused-translation-method
Dec 22, 2025
Merged

Remove unused/legacy translation method from video block#37776
farhan merged 2 commits intomasterfrom
farhan/remove-unused-translation-method

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Dec 17, 2025 •
edited
Loading

Remove unused translation() method

Need of removing:

The removal of un-used methods will decouple the Video Block with the edx-platform or content store.
It will make the Video Block extraction to xblocks-contrib easy. Ticket

History

Introduction of the method
translation() method in video_handlers.py was first introduced used in this PR here while implementing bumper videos functionality.

Discountinue of the usage
While revamping the transcripts functionality in different phases it was removed in the PR here
Till then this method is unused, so this method and its relevant methods should be removed.

Testing Notes:

  1. Video Block is working fine on the content-library/lms/studio.
  2. Video Block editor is working fine on the content-library/lms/studio.

Testing Notes:

Here are the transcripts loading preview on the lms/studio/content-library

Screenshot 2025-12-22 at 4 31 25 PM
Screenshot 2025-12-22 at 4 30 33 PM
Screenshot 2025-12-22 at 4 31 15 PM

@farhan farhan mentioned this pull request Dec 17, 2025
Closed
@farhan farhan requested a review from kdmccormick December 17, 2025 14:31
@farhan farhan force-pushed the farhan/remove-unused-translation-method branch from 74e6134 to 2688000 Compare December 17, 2025 14:58
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Dec 19, 2025
@salman2013
Copy link
Contributor

salman2013 commented Dec 22, 2025

@farhan As per my understanding the code removal is related to transcripts but the testing description you mentioned looks generic for video block running, it would be good if you attach some running transcript results. Otherwise i believe PR looks fine. Thanks

Testing Notes:
Video Block is working fine on the content-library/lms/studio.
Video Block editor is working fine on the content-library/lms/studio.

@farhan
Copy link
Contributor Author

farhan commented Dec 22, 2025

@farhan As per my understanding the code removal is related to transcripts but the testing description you mentioned looks generic for video block running, it would be good if you attach some running transcript results. Otherwise i believe PR looks fine. Thanks

Testing Notes:
Video Block is working fine on the content-library/lms/studio.
Video Block editor is working fine on the content-library/lms/studio.

Thanks for the review, I have attached the screenshots of my testing on the local setup.

salman2013
salman2013 approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@salman2013 salman2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhan farhan merged commit 277481f into master Dec 22, 2025
133 of 134 checks passed
@farhan farhan deleted the farhan/remove-unused-translation-method branch December 22, 2025 12:57
@farhan farhan mentioned this pull request Jan 23, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salman2013 salman2013 salman2013 approved these changes

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner

@kdmccormick kdmccormick Awaiting requested review from kdmccormick

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@farhan @salman2013